Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Parallel aggregations return the wrong results in compiled mode. #1099

Open
lmwnshn opened this issue Aug 19, 2020 · 0 comments · May be fixed by #1211
Open

Parallel aggregations return the wrong results in compiled mode. #1099

lmwnshn opened this issue Aug 19, 2020 · 0 comments · May be fixed by #1211
Assignees
Labels
bug Something isn't working (correctness). Mark issues with this.

Comments

@lmwnshn
Copy link
Contributor

lmwnshn commented Aug 19, 2020

As encountered in #1097, TPL code linked there, parallel aggregations will return the wrong results, e.g.,

terrier=# create table fooc (a int, b int, c int);
CREATE TABLE
terrier=# insert into fooc values (1,2,3);
INSERT 0 1
terrier=# select sum(a), sum(b), sum(c) from fooc;
 ?column? | ?column? | ?column? 
----------+----------+----------
        6 |        6 |        6
(1 row)

With error messages:

[2020-08-19 11:08:18.664] [execution_logger] [error] ERROR IN MODULE:
Stored value type does not match pointer operand type!
  store %1* %16, %"class.terrier::execution::sql::IntegerSumAggregate"** %5
 %"class.terrier::execution::sql::IntegerSumAggregate"*Stored value type does not match pointer operand type!
  store %1* %22, %"class.terrier::execution::sql::IntegerSumAggregate"** %8
 %"class.terrier::execution::sql::IntegerSumAggregate"*Stored value type does not match pointer operand type!
  store %1* %5, %"class.terrier::execution::sql::IntegerSumAggregate"** %2
 %"class.terrier::execution::sql::IntegerSumAggregate"*Stored value type does not match pointer operand type!
  store %1* %7, %"class.terrier::execution::sql::IntegerSumAggregate"** %3
 %"class.terrier::execution::sql::IntegerSumAggregate"*Stored value type does not match pointer operand type!
  store %1* %30, %"class.terrier::execution::sql::IntegerSumAggregate"** %10
 %"class.terrier::execution::sql::IntegerSumAggregate"*Stored value type does not match pointer operand type!
  store %1* %34, %"class.terrier::execution::sql::IntegerSumAggregate"** %12
 %"class.terrier::execution::sql::IntegerSumAggregate"*

For now, static aggregations are being set to SERIAL in #1097.

@lmwnshn lmwnshn added the bug Something isn't working (correctness). Mark issues with this. label Aug 19, 2020
@turingcompl33t turingcompl33t self-assigned this Sep 7, 2020
@turingcompl33t turingcompl33t linked a pull request Sep 29, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working (correctness). Mark issues with this.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants