Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support InListExpr #77

Merged
merged 3 commits into from
Feb 21, 2024
Merged

feat: support InListExpr #77

merged 3 commits into from
Feb 21, 2024

Conversation

Gun9niR
Copy link
Contributor

@Gun9niR Gun9niR commented Feb 19, 2024

This enables tpch Q12 and Q19.

Copy link
Member

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would suggest documenting how we are storing things + what helpers do so other people don't need to go into datafusion doc to search for it.

ExprList::from_rel_node(self.0.child(1)).unwrap()
}

pub fn negated(&self) -> bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what the negated means. Could we add some docs?

@Gun9niR Gun9niR merged commit c8907e3 into main Feb 21, 2024
1 check passed
@Gun9niR Gun9niR deleted the zhidong/in-list-expr branch February 21, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants