Move codegen translators to sub-directory #690

apavlo · 2017-06-06T01:58:18Z

Right now src/include/codegen has almost all of the code for the codegen component. I think that we should move the translators to src/include/codegen/translators to clean up this directory at bit.

I can do this tomorrow on my train ride up to MIT.

@pmenon @seojungmin -- Thoughts?

The text was updated successfully, but these errors were encountered:

seojungmin · 2017-06-06T03:17:22Z

@apavlo I agree that it is an issue, and moving translators into a subdirectory would be a good, first move.

There are other potential candidate files to think about moving into a subdirectory, such as LLVM utility class header files(If/Loop/FunctionBuilder) and maybe proxies, later on. @pmenon What were the other candidates you mentioned last time?

pmenon · 2017-06-06T05:06:13Z

@apavlo Yea, I think that makes sense, especially as we continue to add more stuff.

I was thinking of having a subdirectory for operator, expression, and proxy for operator translators, expression translators, and all the proxy classes, respectively.

apavlo · 2017-06-06T14:10:09Z

I'll take care of this. I'm trying to get started on understanding the LLVM engine.

…odegen/expression' cmu-db#690

…egen/operator' cmu-db#690

…Also renamed 'codegen/utils' to 'codegen/util' cmu-db#690

…amed 'codegen/utils' to 'codegen/util' cmu-db#690

…on::codegen::util namespace cmu-db#690

…odegen/expression' cmu-db#690

…egen/operator' cmu-db#690

…Also renamed 'codegen/utils' to 'codegen/util' cmu-db#690

…amed 'codegen/utils' to 'codegen/util' cmu-db#690

…on::codegen::util namespace cmu-db#690

…odegen/expression' cmu-db#690

…egen/operator' cmu-db#690

…Also renamed 'codegen/utils' to 'codegen/util' cmu-db#690

…amed 'codegen/utils' to 'codegen/util' cmu-db#690

…on::codegen::util namespace cmu-db#690

…e used in the rest of the source code tree cmu-db#690

…e test directory naming scheme cmu-db#690

… to be in the peloton::codegen::lang namespace #690

#690

…e used in the rest of the source code tree #690

…e test directory naming scheme #690

… to be in the peloton::codegen::lang namespace cmu-db#690

cmu-db#690

…mu-db#690

…e used in the rest of the source code tree cmu-db#690

…e test directory naming scheme cmu-db#690

apavlo assigned pmenon and apavlo Jun 6, 2017

apavlo added a commit to apavlo/peloton that referenced this issue Jun 6, 2017

Refactored 'codegen' dir to move ExpressionTranslator classes into 'c…

913669a

…odegen/expression' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 6, 2017

Refactored 'codegen' dir to move OperatorTranslator classes into 'cod…

63af536

…egen/operator' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 6, 2017

Moved codegen::If + codegen::Loop into 'codegen/utils' cmu-db#690

2b326c5

apavlo added a commit to apavlo/peloton that referenced this issue Jun 7, 2017

Refactored 'codegen' dir to move proxy classes into 'codegen/proxy'. …

fa68248

…Also renamed 'codegen/utils' to 'codegen/util' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 7, 2017

Clion's refactor tool didn't pick-up all these corrections when I ren…

e7b041e

…amed 'codegen/utils' to 'codegen/util' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 7, 2017

More renaming of 'codegen/utils' to 'codegen/util' cmu-db#690

8586679

apavlo added a commit to apavlo/peloton that referenced this issue Jun 7, 2017

More refactoring to put the classes in 'codegen/util' under the pelot…

6240580

…on::codegen::util namespace cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 7, 2017

Fixes for the codegen::util namespace cmu-db#690

145ad50

apavlo mentioned this issue Jun 20, 2017

Reorganize codegen source directory #699

Closed

apavlo added a commit to apavlo/peloton that referenced this issue Jun 26, 2017

Refactored 'codegen' dir to move ExpressionTranslator classes into 'c…

855c83c

…odegen/expression' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 26, 2017

Refactored 'codegen' dir to move OperatorTranslator classes into 'cod…

162259c

…egen/operator' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 26, 2017

Moved codegen::If + codegen::Loop into 'codegen/utils' cmu-db#690

7d7e118

apavlo added a commit to apavlo/peloton that referenced this issue Jun 26, 2017

Refactored 'codegen' dir to move proxy classes into 'codegen/proxy'. …

a79b7c9

…Also renamed 'codegen/utils' to 'codegen/util' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 26, 2017

Clion's refactor tool didn't pick-up all these corrections when I ren…

e8f5ec8

…amed 'codegen/utils' to 'codegen/util' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 26, 2017

More renaming of 'codegen/utils' to 'codegen/util' cmu-db#690

966a4a4

apavlo added a commit to apavlo/peloton that referenced this issue Jun 26, 2017

More refactoring to put the classes in 'codegen/util' under the pelot…

4fea9db

…on::codegen::util namespace cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jun 26, 2017

Fixes for the codegen::util namespace cmu-db#690

de9cde2

apavlo added a commit to apavlo/peloton that referenced this issue Jul 4, 2017

Refactored 'codegen' dir to move ExpressionTranslator classes into 'c…

494cef8

…odegen/expression' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jul 4, 2017

Refactored 'codegen' dir to move OperatorTranslator classes into 'cod…

dd57e74

…egen/operator' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jul 4, 2017

Moved codegen::If + codegen::Loop into 'codegen/utils' cmu-db#690

e8b8122

apavlo added a commit to apavlo/peloton that referenced this issue Jul 4, 2017

Refactored 'codegen' dir to move proxy classes into 'codegen/proxy'. …

4717128

…Also renamed 'codegen/utils' to 'codegen/util' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jul 4, 2017

Clion's refactor tool didn't pick-up all these corrections when I ren…

b10f2b0

…amed 'codegen/utils' to 'codegen/util' cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jul 4, 2017

More renaming of 'codegen/utils' to 'codegen/util' cmu-db#690

8d5e185

apavlo added a commit to apavlo/peloton that referenced this issue Jul 4, 2017

More refactoring to put the classes in 'codegen/util' under the pelot…

87dd364

…on::codegen::util namespace cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jul 4, 2017

Fixes for the codegen::util namespace cmu-db#690

dea1223

apavlo added a commit to apavlo/peloton that referenced this issue Jul 9, 2017

Renamed 'codegen::utils' to 'codegen::util' to match the naming schem…

43d7c31

…e used in the rest of the source code tree cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jul 9, 2017

Renamed 'codegen_test_util.*' to 'testing_codegen_util.*' to match th…

1f9e455

…e test directory naming scheme cmu-db#690

apavlo added a commit to apavlo/peloton that referenced this issue Jul 9, 2017

Updated header files for all of the codegen directory files cmu-db#690

70d233f

apavlo added a commit to apavlo/peloton that referenced this issue Jul 9, 2017

Fixed include path for operator sub-classes cmu-db#690

cf9bc0d

apavlo added a commit to apavlo/peloton that referenced this issue Jul 9, 2017

Fixed include path more of the codegen code cmu-db#690

ae42477

apavlo added a commit to apavlo/peloton that referenced this issue Jul 9, 2017

Ran clang-format on all of the codegen directory cmu-db#690

1e79f13

apavlo added a commit to apavlo/peloton that referenced this issue Jul 9, 2017

Ran clang-format on all of the codegen include directory cmu-db#690

e402d28

apavlo added a commit that referenced this issue Jul 9, 2017

Moved If + Loop + VectorizedLoop into 'codegen/lang'. I also set them…

9836bf0

… to be in the peloton::codegen::lang namespace #690

apavlo added a commit that referenced this issue Jul 9, 2017

Moved all of the ExpressionTranslator classes into 'codegen/expression'

66cebb4

#690

apavlo added a commit that referenced this issue Jul 9, 2017

Moved all of the OperatorTranslator classes into 'codegen/operator' #690

10a06b5

apavlo added a commit that referenced this issue Jul 9, 2017

Moved all of the proxy classes into 'codegen/proxy' #690

59a0f27

apavlo added a commit that referenced this issue Jul 9, 2017

Renamed 'codegen::utils' to 'codegen::util' to match the naming schem…

9abb73d

…e used in the rest of the source code tree #690

apavlo added a commit that referenced this issue Jul 9, 2017

Renamed 'codegen_test_util.*' to 'testing_codegen_util.*' to match th…

f3e55d2

…e test directory naming scheme #690

apavlo added a commit that referenced this issue Jul 9, 2017

Updated header files for all of the codegen directory files #690

12e7e1f

apavlo added a commit that referenced this issue Jul 9, 2017

Fixed include path for operator sub-classes #690

3bd8d8c

apavlo added a commit that referenced this issue Jul 9, 2017

Fixed include path more of the codegen code #690

979dd8e

apavlo added a commit that referenced this issue Jul 9, 2017

Ran clang-format on all of the codegen directory #690

3f28dd6

apavlo added a commit that referenced this issue Jul 9, 2017

Ran clang-format on all of the codegen include directory #690

641ed79

apavlo closed this as completed Jul 9, 2017

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Moved If + Loop + VectorizedLoop into 'codegen/lang'. I also set them…

11790eb

… to be in the peloton::codegen::lang namespace cmu-db#690

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Moved all of the ExpressionTranslator classes into 'codegen/expression'

1931192

cmu-db#690

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Moved all of the OperatorTranslator classes into 'codegen/operator' c…

851b3c5

…mu-db#690

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Moved all of the proxy classes into 'codegen/proxy' cmu-db#690

9f87623

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Renamed 'codegen::utils' to 'codegen::util' to match the naming schem…

5c6c23a

…e used in the rest of the source code tree cmu-db#690

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Renamed 'codegen_test_util.*' to 'testing_codegen_util.*' to match th…

af6d3a3

…e test directory naming scheme cmu-db#690

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Updated header files for all of the codegen directory files cmu-db#690

3245551

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Fixed include path for operator sub-classes cmu-db#690

21b5c7e

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Fixed include path more of the codegen code cmu-db#690

51f8964

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Ran clang-format on all of the codegen directory cmu-db#690

e94b548

chenboy pushed a commit to hzxa21/peloton that referenced this issue Jul 10, 2017

Ran clang-format on all of the codegen include directory cmu-db#690

0f1b28a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move codegen translators to sub-directory #690

Move codegen translators to sub-directory #690

apavlo commented Jun 6, 2017

seojungmin commented Jun 6, 2017

pmenon commented Jun 6, 2017

apavlo commented Jun 6, 2017

Move codegen translators to sub-directory #690

Move codegen translators to sub-directory #690

Comments

apavlo commented Jun 6, 2017

seojungmin commented Jun 6, 2017

pmenon commented Jun 6, 2017

apavlo commented Jun 6, 2017