This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
LLVM 3.9 for macOS #1482
Merged
LLVM 3.9 for macOS #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…espite what I removed just being old commented out configs...
|
I dunno why Jenkins isn't running. I'll look again in the morning, but I don't think my changes would have any effect on Jenkins triggering. |
|
Disregard my other stupid comment. I believe I've fixed this in the VM image. A permissions problem for the |
…uild configs that we won't use again.
|
For the record, it worked for me in the other project and I expect it will work here too. I'll submit a PR in the other one shortly. One other change I made was to reduce the number of executors on the macOS build VM from 4 to 1. This will prevent those failures where two build are trying to run |
pervazea
approved these changes
Sep 28, 2018
mtunique
pushed a commit
to mtunique/peloton
that referenced
this pull request
Apr 16, 2019
* Replace LLVM 3.7 with 3.9. * Export new LLVM_DIR. * Replace exported path again. * Remove old, commented out Jenkins targets. * Revert Linux changes. * One more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1478, hopefully.