-
Notifications
You must be signed in to change notification settings - Fork 502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a pass. Looks good too me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigating JUnit failures...
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
- Coverage 81.47% 81.22% -0.25%
==========================================
Files 650 649 -1
Lines 42978 42281 -697
==========================================
- Hits 35015 34343 -672
+ Misses 7963 7938 -25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SET talks directly to the settings manager, poking the values.
With parser SET support yoinked from @thepinetree, thanks!
Known issues
SET foo TO bar,baz
.ActionContext
andSettingsCallback
stuff is not being used byDBMain
or throughout the system.Example usage
Support for invalid values (type mismatch):
Support for invalid values (out of range):
Support for valid value but runtime error:
Support for valid value being set (I don't know how to show a setting, you can see it changed in the error message):
Also added support for DEFAULT. There was a bug with the settings manager that wouldn't let you define more than one string setting, that was fixed.