Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Static PostgresParser #664

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Conversation

mbutrovich
Copy link
Contributor

All of the internal methods are already static, only non-static method is the single public API function. There's no state stored, so just made the entire class static.

This came up while trying to reason about object ownership of PostgresParser when I noticed that there's really no point in instantiating an object to be owned.

@mbutrovich mbutrovich added ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this. best-practice Style fixes or refactor in the code base. Mark issues with this. labels Jan 2, 2020
@mbutrovich mbutrovich self-assigned this Jan 2, 2020
@mbutrovich mbutrovich added ready-to-merge This PR is ready to be merged. Mark PRs with this. and removed ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this. labels Jan 2, 2020
@mbutrovich mbutrovich merged commit f90b38c into cmu-db:master Jan 2, 2020
@mbutrovich mbutrovich deleted the static_postgresparser branch January 7, 2020 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
best-practice Style fixes or refactor in the code base. Mark issues with this. ready-to-merge This PR is ready to be merged. Mark PRs with this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant