-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[covidcast] Add support for querying multiple signals #116
Comments
We may actually prefer to support a fixed list in the GET query, and not *, just because there are so many indicators and variants of indicators in the API. Users who really want everything can use the metadata endpoint to find them all. |
Hey @adamperer @rhansolo, how would you like this data to come back? Example:
Query: Response option 1: add key
Response option 2: Split out
|
Won't we also need to support selecting signals from multiple sources? That would involve specifying (source, signal) pairs, and a source column in the response. |
That would be a much more substantial change in the layout of both the API query and the SQL query. IIRC the immediate use case for this is the cases & deaths views, followed by the single-location view we have planned for future development. For cases and deaths, the map needs to pull (smoothed, raw) X (num, prop) X (incidence, cumulative) to complete ✨ For the single-location view, I'm assuming we want to display all and only the other signals we currently display in the map: doctor-visits x1 + fb-survey x2 + safegraph x2 + ght x1 + combined x1 + jhu-csse/usa-facts x8. With the current API that's 15 queries. With the above support for multiple signals on a single source that's 6 queries. To reduce the number of queries further, the quick and sloppy way would be to replace the |
Robin and Mike prefer Option 2, so we'll go with that. |
…ators#116 * backwards-compatible signal/signals parameter * optional 'format' parameter for retrieving results as a tree (preferred by Viz) or as a flat list (backwards-compatible); defaults to flat list * client support: coffee, js, R, py * integration tests to check multi-signal queries and queries for tree format
This is waiting on #158 to be completed before we can merge. |
…ators#116 * backwards-compatible signal/signals parameter * optional 'format' parameter for retrieving results as a tree (preferred by Viz) or as a flat list (backwards-compatible); defaults to flat list * client support: coffee, js, R, py * integration tests to check multi-signal queries and queries for tree format
Needed for cmu-delphi/www-covidcast#178: Expanded tooltips. Grab
allseveral signals available for a region / set of regions, the same way we can grab all regions.The text was updated successfully, but these errors were encountered: