Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Extract source subdivisions from /covidcast/meta instead of hard-coding #1457

Closed
krivard opened this issue Jan 10, 2022 · 1 comment · Fixed by #1471
Closed
Assignees

Comments

@krivard
Copy link
Contributor

krivard commented Jan 10, 2022

Validator currently hard-codes the mapping from sources to source subdivisions:

source_signal_mappings = {
'chng': ['chng-cli', 'chng-covid'],
'indicator-combination': ['indicator-combination-cases-deaths'],
'quidel': ['quidel-covid-ag'],
'safegraph': ['safegraph-weekly']
}

This means whenever we change the mapping in the spreadsheet (eg for cmu-delphi/delphi-epidata#800), we would need to remember the extra step of updating this hardcoded copy in validator. That is not ideal.

Is this mapping exposed as part of /covidcast/meta? If so, we should have validator look it up there instead. If not, we should add an endpoint to delphi-epidata /covidcast/* to surface it.

@krivard
Copy link
Contributor Author

krivard commented Jan 14, 2022

mata with no arguments gives you db_source and then source for all the member signals, which is exactly this mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants