Remove hard-coding from get_geo_signal_combos #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses covidcast/meta to find source-signal pairings. Issue: how to resolve the db_source quidel mapping to multiple sources quidel_covid_ag and quidel_flu?
Previously, keys weren't unique but values are. Swopped this to fix the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses covidcast/meta to find source-signal pairings, rather than hardcoding values. covidcast/meta stores sources under different names (e.g. quidel_covid_ag instead of quidel). We use a request call to get around this.
Issue: how to resolve the db_source quidel mapping to multiple sources quidel_covid_ag and quidel_flu?
Changelog
Fixes