Example forecaster for modeltools #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dajmcdon This is my example forecaster |
dajmcdon
requested changes
Mar 24, 2021
| @@ -109,7 +109,7 @@ | |||
| #' @importFrom dplyr filter select pull summarize between bind_cols | |||
| #' @importFrom tidyr pivot_longer | |||
| #' @export | |||
| quantgen_forecaster = function(df, forecast_date, signals, incidence_period, | |||
| quantgen_forecaster = function(df_list, forecast_date, signals, incidence_period, | |||
There was a problem hiding this comment.
This signature won't work with the new evalcast. Unless you pass some of these through the forecaster_args() list.
There was a problem hiding this comment.
Most of it is actually unnecessary though.
There was a problem hiding this comment.
The plan is to make it all compliant with the new evalcast although I realize that they are not visible from one another yet.
dajmcdon
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example forecaster to
modeltoolsthat demonstrates how to use themodeltoolsfunctions to construct a forecaster withquantgen.