Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify xpath to account for changed GH html on file lists #586

Merged
merged 1 commit into from Jul 13, 2022

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jul 12, 2022

This morning, the forecast eval pipeline started getting

1. error in evaluating the argument 'x' in selecting a method for function 'as_date': error in evaluating the argument 'x' in selecting a method for function 'as_date': subscript out of bounds

for every forecaster requested. There have been no code changes on our end for the last several months, which implies a problem with one of the APIs or other non-package dependencies we use.

The errors are coming from lubridate attempting to parse dates from data filenames but there not being any dates to parse. It appears that the html of GitHub pages changed slightly so that the existing xpath argument doesn't work (no filenames are found).

This PR modifies the xpath so that we can read the list of files again.

@nmdefries nmdefries marked this pull request as ready for review July 12, 2022 22:04
@dajmcdon dajmcdon removed the request for review from jacobbien July 13, 2022 00:49
@nmdefries nmdefries merged commit e2f761d into evalcast-forecast-eval Jul 13, 2022
@nmdefries nmdefries deleted the ndefries/gh-html-pattern branch July 13, 2022 00:52
@nmdefries
Copy link
Contributor Author

nmdefries commented Jul 19, 2022

@dajmcdon In discussion with @brookslogan, who had the same dates problem in the forecasting plotting pipeline, I realized that since the GitHub html change is outside of the evalcast, all evalcast versions/branches that are currently in use need the same fix applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants