Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare covidcast-R for release 0.5.0 #628

Merged
merged 14 commits into from
Jun 1, 2023
Merged

Conversation

krivard
Copy link
Contributor

@krivard krivard commented May 23, 2023

Includes:

  • Change to the multi-signal vignette: the one-state modification to fit into anonymous request limits had pushed all the subsequent operations to an empty data frame. I dropped the filters and gave you back Texas 馃
  • Version bump
  • Date bump
  • Documentation build - preview

I cleared out all the old docs before building the documentation site, so there are some file removals in this PR for files which are no longer produced by pkgdown. I glanced through them and the only real suspicious one is reference/covidcast.html, but its last modification date in git is from 2 years ago, and I couldn't find anywhere in the current or candidate documentation site that actually links to it; I think all that content got moved to index ages ago.

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some improvements here, and it now passes a check on the R win-builder and on my machine. Would appreciate a double-check of the changes to covidcast.R, the README, and NEWS

Copy link
Collaborator

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave Alex's recent changes a look. Seem fine to me 馃憤

@capnrefsmmat
Copy link
Contributor

Great, I'll go ahead and proceed with CRAN submission.

The server may provide helpful information in its response, so include
this with our error message.
@capnrefsmmat
Copy link
Contributor

Okay, updated the form link and set it to extract error messages on 429 responses. If that's all, I can submit to CRAN soon.

@capnrefsmmat
Copy link
Contributor

Just submitted 0.5.0 to CRAN. Hopefully it goes smoothly this time.

@capnrefsmmat
Copy link
Contributor

Aaand approved:

Dear maintainer,

thanks, package covidcast_0.5.0.tar.gz is on its way to CRAN.

I'll merge this once the package appears on CRAN, so the documentation is updated accordingly.

@capnrefsmmat capnrefsmmat merged commit 54785d8 into main Jun 1, 2023
3 checks passed
@dshemetov dshemetov deleted the krivard/covidcast-r-release branch June 1, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants