-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare covidcast-R for release 0.5.0 #628
Conversation
Presumably, people can handle this error specially in their own pipeline code if they want.
The generated citation generated an invalid link warning under `R CMD check` on some platforms (because of the doi: scheme).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some improvements here, and it now passes a check on the R win-builder and on my machine. Would appreciate a double-check of the changes to covidcast.R
, the README, and NEWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave Alex's recent changes a look. Seem fine to me 馃憤
Great, I'll go ahead and proceed with CRAN submission. |
The server may provide helpful information in its response, so include this with our error message.
Okay, updated the form link and set it to extract error messages on 429 responses. If that's all, I can submit to CRAN soon. |
Just submitted 0.5.0 to CRAN. Hopefully it goes smoothly this time. |
Aaand approved:
I'll merge this once the package appears on CRAN, so the documentation is updated accordingly. |
Includes:
I cleared out all the old docs before building the documentation site, so there are some file removals in this PR for files which are no longer produced by pkgdown. I glanced through them and the only real suspicious one is reference/covidcast.html, but its last modification date in git is from 2 years ago, and I couldn't find anywhere in the current or candidate documentation site that actually links to it; I think all that content got moved to index ages ago.