Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Epidata.auth in covidcast.py #629

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

dmytrotsko
Copy link
Contributor

Epidata.auth should be tuple with "epidata" as first element. This change is done in order to make client to send proper request to the backend

Epidata.auth should be tuple with "epidata" as first element. This change is done in order to make client to send proper request to the backend
@melange396
Copy link
Contributor

Looks good! We should also update

"delphi-epidata>=0.0.11",
to >=4.1.1 to make sure users are also in sync with the client library version (@
delphi-epidata/src/client/packaging/pypi/setup.py ) that actually uses the auth class variable.

@krivard
Copy link
Contributor

krivard commented May 31, 2023

That's a good question: if someone isn't using API keys, they can use delphi-epidata v0.0, but if they are using API keys, they need at least 4.1. What does that mean for how we should set the version dependency in setup.py?

@melange396
Copy link
Contributor

I dont see a reason to make the version dependency anything other than "delphi-epidata>=4.1.1". If someone is not concerned with API keys, and is using delphi-epidata v0.0, but a recent version of this, something strange is going on.

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Updated delphi-epidata version to 4.1.1
@krivard krivard merged commit fd8463a into main Jun 1, 2023
3 checks passed
@krivard krivard deleted the api_keys_authentication_fix branch June 1, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants