bug: fix get_covidhub_forecast_dates #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookslogan
reviewed
Jul 7, 2023
brookslogan
reviewed
Jul 7, 2023
brookslogan
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Looks good to me. I've done a little testing treating it as a black box, and skimmed the code:
- checks pass (except unrelated vdiffr stuff) on my machine
- I can fetch recent forecasts based on the most recent returned date(s). Single or multiple dates as character or Date vectors work.
get_covidhub_predictions("CMU-TimeSeries")doesn't appear to fail when using the default dates from this function, but is taking too long for my unstable internet connection to handle and confirm it completely works.- Some other testing on
get_covidhub_predictionsthat probably doesn't really test these changes...
I'm made some slight code tweaks + some non-blocking really minor suggestions as I correct some misunderstandings I had regarding some purrr and stringr functionality and try to figure out what seem to be clean paradigms we could apply more confidently in messier situations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #646.
My R installation is broken, so I can't run the package locally. Hopefully CI can test it here...