Use fread
instead of arrow
to get data in get_forecaster_predictions_alt
#652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some submitted predictions have a column order that doesn't agree with the
arrow
schema specified inget_forecaster_predictions_alt
. Due to a change in behavior in newer versions ofarrow
, the column order in input files and in thearrow
schema must now be the same (previously were reordered). We pinnedarrow
to a working version as a patch, but that version is now quite old.Incidentally,
arrow
is not providing much additional benefit, so we aren't tied to it. Since we want to prioritize speed,data.table::fread
is a good alternative.data.table
also offers opportunities for future optimization. Sincefread
can read from URL (downloads to a temp file), we don't need to do our own download step, which simplifies the process somewhat.Fixes
Closes #609