Update Python client CHANGELOG #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melange396
requested changes
May 14, 2024
| - Appends a trailing slash to URLs requested by the Python client, which should prevent an automatic redirect and an extra request to the server. | ||
|
|
||
| ### Removed | ||
| - Mutes the covidcast_nowcast endpoint & removes unnecessary code that is related to this endpoint. |
There was a problem hiding this comment.
These notes should be phrased as being from the perspective of the client library and things its users will be interested in:
Suggested change
| - Mutes the covidcast_nowcast endpoint & removes unnecessary code that is related to this endpoint. | |
| - Removed the `covidcast_nowcast()` method, as the associated API endpoint is no longer available. |
Comment on lines
10
to
16
| - https://github.com/cmu-delphi/delphi-epidata/pull/1436 | ||
|
|
||
| ### Added | ||
| - Adds two debug flags: `debug` logs info about HTTP requests and responses; whereas `sandbox` prevents any HTTP requests from actually executing, allowing for tests that do not incur server load. | ||
|
|
||
| ### Changed | ||
| - Updates internal version detection to use `bumpversion`. |
There was a problem hiding this comment.
Lets keep this PR focused on what is already committed; #1436 should make its own updates to the changelog.
Suggested change
| - https://github.com/cmu-delphi/delphi-epidata/pull/1436 | |
| ### Added | |
| - Adds two debug flags: `debug` logs info about HTTP requests and responses; whereas `sandbox` prevents any HTTP requests from actually executing, allowing for tests that do not incur server load. | |
| ### Changed | |
| - Updates internal version detection to use `bumpversion`. | |
| ### Added | |
| - Adds two debug flags: | |
| - `debug` logs info about HTTP requests and responses | |
| - `sandbox` prevents any HTTP requests from actually executing, allowing for tests that do not incur server load. |
There was a problem hiding this comment.
you took out the change from #1418!
Comment on lines
23
to
24
| ### Removed | ||
| - Removes uses of setuptools' deprecated pkg_resources library - these are replaced by the native importlib.metadata library. |
There was a problem hiding this comment.
This was more a replacement than a removal
Suggested change
| ### Removed | |
| - Removes uses of setuptools' deprecated pkg_resources library - these are replaced by the native importlib.metadata library. | |
| ### Changed | |
| - Replaced use of deprecated setuptools' `pkg_resources` library with the native `importlib.metadata` library. |
|
@melange396 fixed! |
dshemetov
previously approved these changes
May 14, 2024
melange396
requested changes
May 15, 2024
| @@ -3,6 +3,31 @@ | |||
| All notable future changes to the `delphi_epidata` python client will be documented in this file. | |||
| The format is based on [Keep a Changelog](http://keepachangelog.com/). | |||
|
|
|||
| ## [4.1.17] - 2024-01-30 | |||
There was a problem hiding this comment.
you forgot to re-add the link to #1418 and that functionality should be under the pending 4.1.21 heading
|
melange396
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1432.
Summary:
Updates the Python client's changelog to include items from previous releases.
Also includes a few currently pending changes. These can be omitted if we want to update the CHANGELOG right away; otherwise the date will need to be updated during the next release.
Prerequisites:
devbranchdev