Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust ahead #296

Open
wants to merge 57 commits into
base: dev
Choose a base branch
from
Open

Adjust ahead #296

wants to merge 57 commits into from

Commits on Jul 30, 2024

  1. fix warnings and empty tests 

    This is purely before any work on latency adjusting, and is just about
geting the tests to run without warnings or skipped tests. Getting this
involved:
1. renaming some lingering examples of p to probs and `q` to
`quantile_levels` (and some `quantile_level`s to the plural)
2. Adding snapshots so the tests for printing in population_scaling work
as intended (should probably be converted to cli_informs at some point)
3. removing the nearly empty `test-propagate_samples` which seems like
something intended that was never finished. Probably want to add an
issue if we actually want it done.
4. added a bunch of `edf`'s in unhappy `prep` steps
    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    26a4e68 View commit details
    Browse the repository at this point in the history

  2. first draft of extend_ahead

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    68cc2e4 View commit details
    Browse the repository at this point in the history

  3. extend_ahead version bump and news

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b1c1892 View commit details
    Browse the repository at this point in the history

  4. styler has opinions

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b24f88f View commit details
    Browse the repository at this point in the history

  5. separate step version

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    da6992b View commit details
    Browse the repository at this point in the history

  6. styler

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2be40bf View commit details
    Browse the repository at this point in the history

  7. tests for utils-latency and accompanying fixes

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ff1a4df View commit details
    Browse the repository at this point in the history

  8. adding stringr

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ab443b7 View commit details
    Browse the repository at this point in the history

  9. old snapshots, select prefers all_of for vectors

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    66f5c6b View commit details
    Browse the repository at this point in the history

  10. local renv way out of date

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9c0cc47 View commit details
    Browse the repository at this point in the history

  11. pkgdown needs @Keywords internal

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    95df4b5 View commit details
    Browse the repository at this point in the history

  12. passes local tests after updating

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f1f6f52 View commit details
    Browse the repository at this point in the history

  13. back to skipping some population_scaling tests

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d5a1dfb View commit details
    Browse the repository at this point in the history

  14. step_adjust_latency works on tests

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3f515d6 View commit details
    Browse the repository at this point in the history

  15. spurious lifecycle addition removed

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7d15a51 View commit details
    Browse the repository at this point in the history

  16. fixing RMDcheck remote

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2a58dc8 View commit details
    Browse the repository at this point in the history

  17. nothing but rlang::abort -> cli::cli_aborts

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7572f94 View commit details
    Browse the repository at this point in the history

  18. smaller suggestions and styling

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2a8d28c View commit details
    Browse the repository at this point in the history

  19. smaller suggestions: local tests passing again

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1d818fd View commit details
    Browse the repository at this point in the history

  20. moving shift detection earlier,dropping string*dep

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1424c7a View commit details
    Browse the repository at this point in the history

  21. +purrr, styling

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    20badd6 View commit details
    Browse the repository at this point in the history

  22. glue -> glue::glue

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9362794 View commit details
    Browse the repository at this point in the history

  23. fix get_latent_column_tibble docs

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    99d265d View commit details
    Browse the repository at this point in the history

  24. step_adjust_latency arg docs

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2cff6bb View commit details
    Browse the repository at this point in the history

  25. rec formatting things, dropping purrr

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3567550 View commit details
    Browse the repository at this point in the history

  26. glue->paste, dropping zoo

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2a1eb9a View commit details
    Browse the repository at this point in the history

  27. Detecting required/forbidden steps beforehand

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f9a30eb View commit details
    Browse the repository at this point in the history

  28. minor rebase woes

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e2b5e6f View commit details
    Browse the repository at this point in the history

  29. tests for utils-latency and accompanying fixes

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5ab558c View commit details
    Browse the repository at this point in the history

  30. adding stringr

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b733d0a View commit details
    Browse the repository at this point in the history

  31. nothing but rlang::abort -> cli::cli_aborts

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a0d8ca1 View commit details
    Browse the repository at this point in the history

  32. moving shift detection earlier,dropping string*dep

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    aace0ea View commit details
    Browse the repository at this point in the history

  33. +purrr, styling

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c3979b2 View commit details
    Browse the repository at this point in the history

  34. rec formatting things, dropping purrr

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1256849 View commit details
    Browse the repository at this point in the history

  35. initial layer adjustments

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0d1452e View commit details
    Browse the repository at this point in the history

  36. namespace and doc fixes

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    daa1baf View commit details
    Browse the repository at this point in the history

  37. full rebase fixes

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5235784 View commit details
    Browse the repository at this point in the history

  38. adding latency adjusting to arx_forecaster

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7b0e969 View commit details
    Browse the repository at this point in the history

  39. arx_classifier more or less free

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2c065f4 View commit details
    Browse the repository at this point in the history

  40. formatting and snapshots

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8f73ed8 View commit details
    Browse the repository at this point in the history

  41. updated man pages

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    dc6e4ee View commit details
    Browse the repository at this point in the history

  42. group_by options to get the max_time_value

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b523846 View commit details
    Browse the repository at this point in the history

  43. PR review recs 

    - drop multiline pipes
- better docs
- check exclusive parameters aren't used simultaneously
- inherit typo
- additional placeholders for future tests
    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2316366 View commit details
    Browse the repository at this point in the history

  44. typo in multiline pipe replacement

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6ba3fac View commit details
    Browse the repository at this point in the history

  45. happy styler

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7d5846e View commit details
    Browse the repository at this point in the history

  46. various requested changes, check passes

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0b16022 View commit details
    Browse the repository at this point in the history

  47. style fix

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ab5b817 View commit details
    Browse the repository at this point in the history

  48. inheritParams, correct print, test adjust subset

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1ddd6d5 View commit details
    Browse the repository at this point in the history

  49. space

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4cd137e View commit details
    Browse the repository at this point in the history

  50. print fix and tests

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    aea2737 View commit details
    Browse the repository at this point in the history

  51. multi-aheads do work

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f312fde View commit details
    Browse the repository at this point in the history

  52. arx_fc better fc_date info, docs

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6723e56 View commit details
    Browse the repository at this point in the history

  53. classifier latency ahead adjustment

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2f8090d View commit details
    Browse the repository at this point in the history

  54. refactor step_adjust_ahead to be early step

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    02659f2 View commit details
    Browse the repository at this point in the history

  55. moving locf to step_adjust_ahead instead of get_test_data

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f805ec1 View commit details
    Browse the repository at this point in the history

  56. hotfix from Dan

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a28ad82 View commit details
    Browse the repository at this point in the history

  57. rebase fixes, error classes, unskip latency tests

    @dsweber2
    dsweber2 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    986b657 View commit details
    Browse the repository at this point in the history