Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a complete method for epi_dfs #250

Open
brookslogan opened this issue Dec 2, 2022 · 2 comments
Open

Add a complete method for epi_dfs #250

brookslogan opened this issue Dec 2, 2022 · 2 comments
Labels
enhancement New feature or request P1 medium priority

Comments

@brookslogan
Copy link
Contributor

Currently, we expect users to appropriately tidyr::complete their data appropriately before using with some epiprocess functionality, but complete on epi_dfs drops epi_df-ness; we should stop that from happening. (If we were to enforce key uniqueness, this might need to be done carefully or with some additional checks, but since we don't, it's probably just unconditionally reclassing or dplyr_reconstructing).

@brookslogan
Copy link
Contributor Author

Adding a complete method may not be the "right" approach. It might naturally fall out of fixing more core functionality like joins. Related: #223.

@brookslogan
Copy link
Contributor Author

Migrating from #138.

This might be a tool to use in #256; if we want to complete slide inputs, we may need a complete / gap-filling method for that works across both epi_dfs and tibbles (depending on whether our slide inputs have been decayed into tibbles or are still epi_dfs). tidyr::complete may or may not work for this already, but it's probably what we want to use. We're trying to avoid heavy tidyverts dependencies now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 medium priority
Projects
None yet
Development

No branches or pull requests

1 participant