Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gap filling and other S3 issues #138

Closed
dajmcdon opened this issue Jul 8, 2022 · 4 comments
Closed

Gap filling and other S3 issues #138

dajmcdon opened this issue Jul 8, 2022 · 4 comments
Labels
enhancement New feature or request P2 low priority

Comments

@dajmcdon
Copy link
Contributor

dajmcdon commented Jul 8, 2022

Reposting from @qpmnguyen via Slack:

When using epiprocess with tsibble, I have to switch back and forth between the two data types (epi_df and tsibble) in order to use their functionality (e.g. use epi_slide after gap filling)

@dajmcdon
Copy link
Contributor Author

dajmcdon commented Jul 8, 2022

@brookslogan response:

Easier fixes might try to address particular bumps, e.g., provide our own gap-filling function, or epi_df implementations of tsibble S3 methods (that might just convert to tsibble, call tsibble implementation, convert back to epi_df). So maybe Quang could list any other situations that this happened and we could add epiprocess functions accordingly. Harder fixes and/or breaking changes might try to support tsibble-backed epi_dfs in addition to, or instead of, tibble-backed ones.

@dajmcdon
Copy link
Contributor Author

dajmcdon commented Jul 8, 2022

related to #117

@brookslogan brookslogan added P2 low priority enhancement New feature or request labels Aug 1, 2022
@brookslogan
Copy link
Contributor

This might be a tool to use in #256; if we want to complete slide inputs, we may need a complete / gap-filling method for that works across both epi_dfs and tibbles (depending on whether our slide inputs have been decayed into tibbles or are still epi_dfs). tidyr::complete may or may not work for this already, but it's probably what we want to use. We're trying to avoid heavy tidyverts dependencies now.

@brookslogan
Copy link
Contributor

I don't think there's an easy way to smooth out the tsibble stuff. What's left here is probably #250 + the extra issues in #223 &co.

@brookslogan brookslogan closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 low priority
Projects
None yet
Development

No branches or pull requests

2 participants