Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enh] promote other_keys #446

Open
dajmcdon opened this issue May 3, 2024 · 1 comment · May be fixed by #460
Open

[enh] promote other_keys #446

dajmcdon opened this issue May 3, 2024 · 1 comment · May be fixed by #460
Assignees
@dsweber2
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
[Idea] Wishlist

Comments

@dajmcdon
Copy link
Contributor

dajmcdon commented May 3, 2024

Can we move other_keys out of the additional_metadata List? This seems like, by far, the most common use case we've seen for this list. And it already has its own special handling in the new_epi_df() constructor.
@dajmcdon dajmcdon added enhancement New feature or request good first issue Good for newcomers labels May 3, 2024
@dajmcdon dajmcdon added this to the [Idea] Wishlist milestone May 3, 2024
@brookslogan
Copy link
Contributor

Yeah, we definitely need to get to this, and just remove the other additional_metadata. We don't handle that any better than direct attrs.

Probably a dupe of #186

@brookslogan brookslogan mentioned this issue Jun 5, 2024
Open
@dsweber2 dsweber2 self-assigned this Jun 7, 2024
@dsweber2 dsweber2 linked a pull request Jun 7, 2024 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsweber2 dsweber2

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
[Idea] Wishlist
Development

Successfully merging a pull request may close this issue.

epi_df argument refactoring cmu-delphi/epiprocess
3 participants
@dsweber2 @dajmcdon @brookslogan