-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Promote" other_keys
to be printed, a constructor parameter, and more clearly documented
#186
Comments
We should probably also make |
And we should also print the rest of the epikey in |
We need to regenerate the saved data sets (here and in other repos) after this change, or maybe right now due to the |
When "you say after this change", are you referring to the default of |
Migrated from #113 and #183.
print.epi_df
should print theother_keys
metadata.other_keys
should be its own parameter tonew_epi_df
andas_epi_df
epi_df
, and googling "tibble key" is surprisingly unhelpful (currently giving links to lock picks and decoder tools) [so the{new,as}_epi_df
docs may need explication]. Maybe explaining this could just be rolled into the issue for addingother_keys
as a parameter, though; it'd be easier to do in its own@param
.If this is causing recurring issues in epipredict maybe it should be changed to higher priority.
The text was updated successfully, but these errors were encountered: