Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using dots, use line too. Make points smaller but still scale with pop. #97

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

nmdefries
Copy link
Contributor

I wasn't able to test this due to set-up problems. This should run, but point size may not be ideal.

@dsweber2
Copy link
Contributor

Found the dashboard example of the points being too large that we ran into when talking about this:
image
I guess the problem is the point size is relative to the overall interface, rather than the size of the sub-plot? Part of the problem is that the new forecasters have way more points than the old ones, so they get really big in e.g. this plot
image

Either way, I think it'll be useful to make sure that all the kinks are worked out in other people running the dashboard.

The lines are definitely helpful.

@nmdefries
Copy link
Contributor Author

Okay, so maybe scale the point size by # of subplots.

@dsweber2
Copy link
Contributor

That did it!
image

@nmdefries nmdefries merged commit 10dd618 into main Feb 20, 2024
1 check passed
@nmdefries nmdefries deleted the ndefries/dots-toggle branch February 20, 2024 23:05
@nmdefries nmdefries mentioned this pull request Feb 20, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants