Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only redo data process and plotting for exclusions when user pushes button #98

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

nmdefries
Copy link
Contributor

Add "apply exclusions" button. Selecting aheads or states to exclude will NOT automatically update the plots.

Closes #77

@@ -57,7 +57,7 @@ load_forecast_data <- memoise::memoise(load_forecast_data_raw, cache = cache)
prepare_forecaster_table <- function(selected_forecasters) {
forecasters <- tar_read(forecaster_params_grid) %>%
select(-id) %>%
mutate(across(where(is.list), map, `%||%`, c(0, 7, 14))) %>%
mutate(across(where(is.list), function(x) { map(x, `%||%`, c(0, 7, 14)) })) %>%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this prevents across from warning that passing args via ... is deprecated.

Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@nmdefries nmdefries merged commit e7f8ad9 into main Feb 21, 2024
1 check passed
@nmdefries nmdefries deleted the ndefries/states-exclusions-button branch February 21, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various Plotting improvements
2 participants