Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing county level to quidel #460

Merged
merged 4 commits into from Oct 14, 2020
Merged

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Sep 21, 2020

according to meta data we have it

closes #539

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

according to meta data we have it

according to meta data we have it
@capnrefsmmat
Copy link
Contributor

This may have been a deliberate decision because of low sample sizes, although it looks like that has gotten better in the past month or so. We might get someone to play with the preview for a minute to see if they think the Quidel county signal is available at enough counties to release.

@sgratzl sgratzl added this to In Review/Testing in COVIDCast Ongoing Development Sep 23, 2020
@adamperer adamperer requested review from capnrefsmmat and removed request for adamperer September 24, 2020 14:06
@capnrefsmmat
Copy link
Contributor

@jingjtang Viz is considering turning on county-level maps for the Quidel COVID tests. Do you recall why we originally didn't have this? Was it just the sample size? If so, is the sample size large enough now that we should turn it on?

@jingjtang
Copy link

jingjtang commented Sep 24, 2020

@capnrefsmmat This figure shows the number of counties available to be reported, the requirement is

  • Sample size >= 50 for raw
  • Sample size >0 for smoothed

image

@capnrefsmmat
Copy link
Contributor

Since we display the smoothed signal on the map, I think we can go ahead and display the smoothed Quidel signal at the county level. @jingjtang There isn't any reason that counties are not comparable or are misleading, right?

@jingjtang
Copy link

jingjtang commented Sep 24, 2020

@capnrefsmmat They should be comparable among counties since we report percent of positive tests which are number of positive tests / number of total tests * 100 for a certain location in a certain time period.

There is only one concern left. We have add an extra threshold for geographical pooling as stated here. The code has been finished, but the data in the system has not been updated(all the data back to May 26) and the documentation for the API is left as the old version. What is the time point to do the two things? (@krivard is not here this week) I think we should do these two things together so that the documentation for the API is consistent with the data people get from our API.

This change will lead to fewer counties available since we only report counties with sample size >= 30 as shown below. (sorry, the figure that I posted previously is for the old version, corrected in the last comment).

The requirement is

  • Sample size >= 50 for raw
  • Sample size >=30 for smoothed
    image

@netlify
Copy link

netlify bot commented Oct 13, 2020

Preview link ready!

Built with commit cc537c9

https://deploy-preview-460--cmu-delphi-covidcast.netlify.app

@sgratzl sgratzl linked an issue Oct 13, 2020 that may be closed by this pull request
Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we now have #544 to explicitly mention coverage, I think it's reasonable to enable this signal at the county level.

@tildechris tildechris merged commit e3b4eae into dev Oct 14, 2020
COVIDCast Ongoing Development automation moved this from In Review/Testing to Done Oct 14, 2020
@tildechris tildechris deleted the sgratzl/quidel_county branch October 14, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Enable COVID antigen test signals at the county level
5 participants