Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHOSTS do not wake on UtcTimeOn #334

Closed
vydrazde opened this issue May 2, 2024 · 6 comments
Closed

GHOSTS do not wake on UtcTimeOn #334

vydrazde opened this issue May 2, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@vydrazde
Copy link

vydrazde commented May 2, 2024

In v8, the handlers are not run when sleeping and UtcTimeOn time passes.

I was not able to debug this properly as I was not able to setup the local development environment, but I believe the issue is in this loop (or the loop above)

var currentTime = DateTime.UtcNow.TimeOfDay;
...
while (currentTime < timeOn || currentTime > timeOff)
{
    Sleep(handler, 60000);
}

where the currentTime does not get updated within the loop, so it becomes stuck.

sei-dupdyke pushed a commit that referenced this issue May 2, 2024
sei-dupdyke pushed a commit that referenced this issue May 2, 2024
sei-dupdyke added a commit that referenced this issue May 2, 2024
@sei-dupdyke
Copy link
Contributor

I just pushed v8.0.14 clients to fix this, thank you for the catch. I wonder if this is related to discussion #327?

@vydrazde
Copy link
Author

vydrazde commented May 2, 2024

Thanks for the quick fix!
I tested on Win 10 and Win 7, so I don't think #327 is related. Could you also push a new Win client so I can test the fix?

@sei-dupdyke sei-dupdyke added the bug Something isn't working label May 3, 2024
@sei-dupdyke
Copy link
Contributor

Windows 8.0.14 should be out there as the default download. Thanks!!

@vydrazde
Copy link
Author

vydrazde commented May 4, 2024

OK, I have the Windows 8.0.14 version as per

Info|Ghosts.Client.Infrastructure.DebugManager.Write|GHOSTS (ghosts:8.0.0.0 [8.0.14.0]) running in production mode

But in the logs I still see

Trace|Ghosts.Domain.Code.WorkingHours.Sleep|Ghosts.Domain.TimelineHandler sleeping for 60000 ms

repeatedly and the handler does not wake.
So either the build is not up-to-date or I have an older build and the version is not shown correctly?
The sha256 of my ghosts.exe is E0B3280CAB5D299EE01EADCDDC987AE7FD69A09119C9DF59758BD09436990423

@sei-dupdyke
Copy link
Contributor

Ok, sorry about that, 8.0.16 is out there now and should fix the issue. #338

@vydrazde
Copy link
Author

vydrazde commented May 4, 2024

Yes, that works, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants