Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default Vega-Lite-based renderer (#342) #438

Merged
merged 50 commits into from
Dec 14, 2022
Merged

feat: default Vega-Lite-based renderer (#342) #438

merged 50 commits into from
Dec 14, 2022

Commits on Nov 1, 2022

  1. feat: create examples-vl notebook 

    We can delete this before merging, but the nb should be useful for discussions
    @peter-gy
    peter-gy committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3de1ba4 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. feat: base renderer progress

    @peter-gy
    peter-gy committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    932ed30 View commit details
    Browse the repository at this point in the history

  2. refactor: extract renderer base

    @peter-gy
    peter-gy committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    50e0dfd View commit details
    Browse the repository at this point in the history

  3. ci: set up python before installing stuff

    @domoritz
    domoritz committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    535dcb4 View commit details
    Browse the repository at this point in the history

  4. rm poetry

    @domoritz
    domoritz committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    6f33063 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. feat: AltairRenderer stable impl 

    Renders all the example charts
    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    01e2eba View commit details
    Browse the repository at this point in the history

  2. chore: update mypy 

    The previous version crashed for some cases including `Generic` types
    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    43644e6 View commit details
    Browse the repository at this point in the history

  3. refactor: satisfy type analyzers

    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    182c8d1 View commit details
    Browse the repository at this point in the history

  4. chore: merge main

    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    705a68f View commit details
    Browse the repository at this point in the history

  5. chore: bump wheel 

    maybe fixes failing CI job https://github.com/cmudig/draco2/actions/runs/3439166059/jobs/5736131475
    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    68e65e8 View commit details
    Browse the repository at this point in the history

  6. docs: document renderer

    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    f15dda8 View commit details
    Browse the repository at this point in the history

  7. docs: document types

    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    2630f61 View commit details
    Browse the repository at this point in the history

  8. chore: update poetry.lock

    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    9f8162d View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/code-scanning' into feat/342-def… 

    …ault-renderer

Needed to pull in CI fix
    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    01ec390 View commit details
    Browse the repository at this point in the history

  10. chore: downgrade wheel

    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    fc68609 View commit details
    Browse the repository at this point in the history

  11. test: test types 

    cover validators
    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    2c9cac7 View commit details
    Browse the repository at this point in the history

  12. refactor: remove unused utility method

    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    1da11b6 View commit details
    Browse the repository at this point in the history

  13. test: increase renderer coverage

    @peter-gy
    peter-gy committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    d7a789e View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. chore: add deepdiff as dev dep 

    Aids VL-renderer debugging
    @peter-gy
    peter-gy committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    2831d86 View commit details
    Browse the repository at this point in the history

  2. test: use DeepDiff in vl_specs_equal

    @peter-gy
    peter-gy committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    56926dc View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. chore: merge main

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d961948 View commit details
    Browse the repository at this point in the history

  2. test: single view - single mark

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    1f1de2c View commit details
    Browse the repository at this point in the history

  3. test: stacked

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d8a7089 View commit details
    Browse the repository at this point in the history

  4. fix: handle layering properly

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    e098422 View commit details
    Browse the repository at this point in the history

  5. test: Multi Mark (Layered)

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    53d47ce View commit details
    Browse the repository at this point in the history

  6. fix: type checker error thrown by unbounded generic

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    88ef8ef View commit details
    Browse the repository at this point in the history

  7. test: facets

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    7727e25 View commit details
    Browse the repository at this point in the history

  8. test: multi view

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    e59d9a8 View commit details
    Browse the repository at this point in the history

  9. chore: do not cover unreachable code

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ebe3d78 View commit details
    Browse the repository at this point in the history

  10. test: unknown field in spec raises

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ea26fe7 View commit details
    Browse the repository at this point in the history

  11. test: cover all marks and encodings

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    cc802f6 View commit details
    Browse the repository at this point in the history

  12. chore: merge main

    @peter-gy
    peter-gy committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    5c53486 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. feat: validate polar marks in schema

    @peter-gy
    peter-gy committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    bcaa8fe View commit details
    Browse the repository at this point in the history

  2. test: polar mark validator

    @peter-gy
    peter-gy committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    0925055 View commit details
    Browse the repository at this point in the history

  3. feat: validate polar encodings in schema

    @peter-gy
    peter-gy committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    1d972e0 View commit details
    Browse the repository at this point in the history

  4. test: polar encoding validator

    @peter-gy
    peter-gy committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    8910c7a View commit details
    Browse the repository at this point in the history

  5. feat: support rendering polar charts

    @peter-gy
    peter-gy committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    94dc9e9 View commit details
    Browse the repository at this point in the history

  6. test: polar charts

    @peter-gy
    peter-gy committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ea7e7a7 View commit details
    Browse the repository at this point in the history

  7. feat: handle multi views 

    Support on-demand concats
    @peter-gy
    peter-gy committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    bb7547a View commit details
    Browse the repository at this point in the history

  8. test: multi views

    @peter-gy
    peter-gy committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    dfada10 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. chore: merge main

    @peter-gy
    peter-gy committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    6a36bad View commit details
    Browse the repository at this point in the history

  2. fix: satisfy CodeQL 

    Attempts to fix "Explicit returns mixed with implicit (fall through) returns"
    @peter-gy
    peter-gy committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    76795ec View commit details
    Browse the repository at this point in the history

  3. refactor: move vega-specific spec to altair package

    @peter-gy
    peter-gy committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    d6f06a8 View commit details
    Browse the repository at this point in the history

  4. ci: pin runners to ubuntu-20.04 

    Fixes actions/setup-python#162
    @peter-gy
    peter-gy committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    8b96f55 View commit details
    Browse the repository at this point in the history

  5. docs: explain the purpose of the stroke in __visit_mark_polar

    @peter-gy
    peter-gy committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    320cf54 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. refactor: declare methods as static where applicable

    @peter-gy
    peter-gy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    aac04b9 View commit details
    Browse the repository at this point in the history

  2. docs: document scale options of SpecificationDict 

    A spec has either top-level- or view-level scales or both.
    @peter-gy
    peter-gy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    39e400a View commit details
    Browse the repository at this point in the history

  3. feat: consider scale type in __get_field_type 

    Adds support for determining Vega-Lite field type
based on a combination of the scale type and the field's
raw data type
    @peter-gy
    peter-gy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4e380ec View commit details
    Browse the repository at this point in the history

  4. refactor: adjust dict in __get_field_type

    @peter-gy
    peter-gy committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    bd7ca3b View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. fix: distinguish __get_scale_for_encoding and `__get_alt_scale_for_… 

    …encoding`
    @peter-gy
    peter-gy committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    25659fe View commit details
    Browse the repository at this point in the history