docs: draco1 vs draco2 comparison notebook
#666
Conversation
| "| List ASP problem violations | ✅`drc1.Result.violations.keys` | ✅`drc2.get_violations` |\n", | ||
| "| Show how often a spec violates a preference | ✅`drc1.Result.violations` | ✅`drc2.count_preferences` |\n", | ||
| "| Generate ASP definitions from data | ✅ `drc1.data_to_asp` | ✅`drc2.schema_from_dataframe` |\n", | ||
| "| Conversion between spec formats | ✅ ASP ↔️Vega-Lite, CompassQL | ✓ ASP ↔️Nested dictionary, Vega-Lite |\n", |
There was a problem hiding this comment.
| "| Conversion between spec formats | ✅ ASP ↔️Vega-Lite, CompassQL | ✓ ASP ↔️Nested dictionary, Vega-Lite |\n", | |
| "| Conversion between spec formats | ✅ ASP ↔️Vega-Lite, CompassQL | ✅ ASP ↔️Nested dictionary, Vega-Lite |\n", |
draco/fact_utils.py
Outdated
| @@ -148,3 +151,17 @@ def answer_set_to_dict(answer_set: Iterable[Symbol], root=ROOT) -> Mapping: | |||
| collector[obj][prop] = collector[obj].get(prop, []) + [child] | |||
|
|
|||
| return collect_children(root, collector) | |||
|
|
|||
|
|
|||
| def facts_to_dict(facts: Specification) -> Mapping: | |||
There was a problem hiding this comment.
Hmm, I wonder whether we need this utility method or whether we better let people write it manually to make it clear what's happening. I would vote for not having a utility method.
There was a problem hiding this comment.
I see what you mean. I added this method to have a one-liner conversion method, just like Draco 1 has. Given that we argue that Draco 2 has a nicer API, I figured it would come across as contradictory in the comparison notebook to have a seemingly more complex conversion flow in Draco 2 than what we have in Draco 1.
But since we would only benefit from this utility in the comparison notebook, we can probably live with this one-liner too:
answer_set_to_dict(next(run_clingo(facts)).answer_set)I'll revert the changes.
There was a problem hiding this comment.
Short code isn't necessarily better. Composable APIs (imo) are best (with some caveats as it makes sense to have shortcuts for very common calls).
Needed by draco1 as an executable
Creates only a base for the notebook to be built on top of
Needed since Draco 1 executions requires a Node.js runtime
peter-gy
force-pushed
the
docs/draco1-vs-draco2-notebook
branch
from
8d1e098
to
5aa8e53
Compare
No description provided.