Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viz update required #3

Closed
jayolee opened this issue Sep 27, 2019 · 8 comments
Closed

viz update required #3

jayolee opened this issue Sep 27, 2019 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@jayolee
Copy link
Collaborator

jayolee commented Sep 27, 2019

Couldn't update the viz since we need to save the file according to the coordination number.

@laurafulton laurafulton added this to the Existing Issues milestone Oct 13, 2019
@laurafulton laurafulton added the bug Something isn't working label Oct 13, 2019
@laurafulton
Copy link
Contributor

Examples of this (shows up not just in selection screen, error persists in other parts of game (see second image)):
Screen Shot 2019-10-13 at 4 39 43 PM
Screen Shot 2019-10-13 at 3 59 22 PM

@adamperer
Copy link
Member

Waiting for @shivanggupta to provide code fix.

@yzd1998111
Copy link
Collaborator

The cause of this issue is that the correct/wrong hint image numbers are hardcoded but some of them cannot be found in the img directory. I marked them in the file to be fixed later.

@yzd1998111 yzd1998111 assigned laurafulton and unassigned jayolee Oct 28, 2019
@shivanggupta
Copy link

shivanggupta commented Oct 29, 2019 via email

@adamperer
Copy link
Member

Thanks @shivanggupta. Please let us know if you expect delays beyond Saturday.

@shivanggupta
Copy link

I'm unable to fix the code on the repo itself but it's working on my laptop, could @laurafulton or @yzd1998111 please give me a call and I will share the fix with them directly so they can update it. I will be in a design sprint all week but I can be reached by email and I'll share my phone number, I can talk after 5 pm on any day this week.

@adamperer
Copy link
Member

@yzd1998111 do you have time one night this week to discuss this issue with @shivanggupta ? If so, @shivanggupta , please share your contact info.

For context, @yzd1998111 , this is the issue where the numbers were higher than the images we had. For now, you had replaced those higher numbers manually. This should be a fix for that issue.

@yzd1998111
Copy link
Collaborator

When would you be available next week? @shivanggupta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants