Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing to print_buffer corrupts memory #63

Open
mahkoh opened this issue Oct 5, 2013 · 3 comments
Open

Writing to print_buffer corrupts memory #63

mahkoh opened this issue Oct 5, 2013 · 3 comments
Labels

Comments

@mahkoh
Copy link
Member

mahkoh commented Oct 5, 2013

When the declaration of print_buffer is moved around a bit and print_buffer is resized appropriately (20 bytes for me), cmus crashes with a segfault.

@flyingmutant
Copy link
Member

Can you please provide a backtrace, or more detailed steps to reproduce the issue?

@mahkoh
Copy link
Member Author

mahkoh commented Oct 5, 2013

https://gist.github.com/mahkoh/6461733b07c0a10e964e

It's clear what happens: format_str and other functions don't take a buffer size argument. This is not an issue on my system because format_str writes at most 4*{width of screen} bytes. But it should be fixed anyway.

@pgaskin
Copy link
Collaborator

pgaskin commented Dec 13, 2020

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants