Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build #251

Merged
merged 5 commits into from
Jun 9, 2022
Merged

Fix windows build #251

merged 5 commits into from
Jun 9, 2022

Conversation

dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Jun 9, 2022

No description provided.

@dhdaines
Copy link
Contributor Author

dhdaines commented Jun 9, 2022

Windows tests are partially fixed by putting everything in the same directory as the DLL, and some adjustments were made so that this works on Unix as well. It's perhaps not the optimal solution, we may prefer to copy the DLL to the programs directory and to a single directory to hold the test binaries. Tests also need to be fixed on Windows as they depend on bash.

@dhdaines dhdaines merged commit 0d101b4 into master Jun 9, 2022
@dhdaines dhdaines deleted the cmake_windows_build branch September 21, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant