-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incoporate WebRTC VAD code #278
Conversation
Note that supporting 44.1kHz is fairly easy (if not really optimal) as the code to resample the input to an acceptable sampling rate (i.e. a multiple of 8kHz) is already present in the code, just not hooked into the actual VAD API. The reason it can't be done without resampling is that the VAD code, for very good reasons, relies on filters designed and optimized for 8kHz sampled data. Arguably the right approach would be to have a parallel set of filters for 11025Hz data, which is, unfortunately, beyond my abilities in DSP. |
lets go shopping
Incoporate the more or less industry-standard VAD code from WebRTC. Still a draft as it is missing some really important features:
Having this checked in will allow us to unit test it when we add these missing features.