This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe this is mentioned anywhere in the spec, but it is an important detail: the sort order of conditionsets in the FeatureVariations table has meaningful impact on whether a variation is applied, since we apply the first set of variations that is encountered.
With this patch, we match the order used by fonttools, which is (as far as I can deduce) based on the order in which a given conditionset is first referenced by a lookup.
There is some behaviour in fonttools I still do not fully understand, so I will open a discussion issue there.