Add support for ECS task role #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnonino
approved these changes
Sep 17, 2021
CN Services - Terraform Modules
automation
moved this from In progress
to Reviewer approved
Sep 17, 2021
|
Released in version 1.0.17. Thanks for your contibution!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for (optional) usage of an ECS task role in the module.
Currently, if the provided Task Definition uses an ECS task role, the built-in IAM role will fail because it is not included in the "iam:PassRole" statement in the "scheduled_task_cw_event_role_cloudwatch_policy" IAM policy document.