Fix CodeDeploy compatibility issues / Adds additional load balancer feature / Fixes tests #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JaredDarling
commented
Sep 30, 2023
JaredDarling
commented
- Adds lifecycle ignore to handle extenal deployments
- Adds support for additional load balancer feature
- Reference correct alb version to enable additional_lb support and CodeDeploy support
- Updates tests to comply with latest cn-terraform/networking/aws implementation
* Upgrade cn-terraform/ecs-alb/aws -> 1.0.29 * makes task_definition dynamic * Add default for deployment_controller * Adds lifecycle ignore to handle extenal deployments * Adds networking_configuration to ignore_changes * Formatting * Adjust logic to only EXTERNAL' * Adds support for additional load balancer feature * Add load_balancer to ignore_changes for ECS service * Remove load_balancer from ignore_changes, causes invalid config. * Reference correct alb version to enable additional_lb support and CodeDeploy support * Updates tests to comply with latest cn-terraform/networking/aws implementation --------- Co-authored-by: Jared Darling <jdarling@aimconsulting.com>
JaredDarling
changed the title
jnonino
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.