feat(bundle_test.go): add yaml marshal test for bundle #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2019
vdice
force-pushed
the
feat/location-yaml-tags
branch
2 times, most recently
from
8b0cad3
to
80d75a9
Compare
vdice
force-pushed
the
feat/location-yaml-tags
branch
from
80d75a9
to
a868617
Compare
vdice
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds yaml tags to theLocationstruct for third-party consumers representing these structs in yaml. See also #90 for precedence.Even though this covers the extent of our needs in Porter as of writing, I'd be willing to add yaml tags to all of the structs, as there may be other uses in the future. What do we think?Edit: #95 covers adding yaml tags to all structs; therefore this PR now just represents some added tests
Note that the test amendments are largely just extracting the
exampleCredandexampleBundlevars to the top-level such that multiple tests can make use of them. Also added an additionalPathfield to the"port"parameterDestinationfield, for verification in the added yaml test.