Rename import package to reflect future org change to cnabio
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because the import path for the package does not match the directory structure in However, cloning in the correct directory works: Do we want to first move the repo under the new organization, then merge this PR? |
|
This needs a rebase on top of #47. |
added 2 commits
February 13, 2020 14:36
Signed-off-by: Radu M <root@radu.sh>
Signed-off-by: Radu M <root@radu.sh>
radu-matei
force-pushed
the
move-cnabio
branch
from
3253f5c
to
e243fd5
Compare
Signed-off-by: Radu M <root@radu.sh>
|
Rebased on top #47. |
radu-matei
commented
Feb 13, 2020
| mkdir -p $GOPATH/src/github.com/$GITHUB_REPOSITORY | ||
| mv $(pwd)/* $GOPATH/src/github.com/$GITHUB_REPOSITORY | ||
| cd $GOPATH/src/github.com/$GITHUB_REPOSITORY | ||
| export GOPATH=$HOME/go && export GOBIN=$(go env GOPATH)/bin && export PATH=$PATH:$GOPATH&& export PATH=$PATH:$GOBIN && mkdir -p $GOBIN |
There was a problem hiding this comment.
At some point we might want to tweak the Makefile to not need a GOPATH anymore, I'll open a separate issue about it.
radu-matei
commented
Feb 13, 2020
| @@ -75,7 +75,7 @@ INFO[0001] The software product passed all verification. | |||
| cmd.Flags().StringVarP(&verify.localFile, "local", "", "", "Local file to validate the SHA256 against (mandatory for thick bundles)") | |||
|
|
|||
| cmd.Flags().BoolVarP(&verify.intoto, "in-toto", "", false, "If passed, will try to fetch in-toto metadata from TUF and perform the verification") | |||
| cmd.Flags().StringVarP(&verify.verificationImage, "image", "", "docker.pkg.github.com/engineerd/in-toto-container/verification:v1", "container image to run the in-toto verification") | |||
| cmd.Flags().StringVarP(&verify.verificationImage, "image", "", "docker.pkg.github.com/cnabio/in-toto-container/verification:v1", "container image to run the in-toto verification") | |||
There was a problem hiding this comment.
This also means we must push the verification image to cnabio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preparing the moving of this repo into github.com/cnabio, the official GitHub organization for CNAB projects.
This PR:
github.com/engineerd/signytogithub.com/cnabio/signy.