Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cdi: update/fix go.{mod,sum}. #106

Merged
merged 1 commit into from
Feb 2, 2023
Merged

cmd/cdi: update/fix go.{mod,sum}. #106

merged 1 commit into from
Feb 2, 2023

Conversation

klihub
Copy link
Contributor

@klihub klihub commented Feb 2, 2023

Update cmd/cdi/go.{mod,sum} to fix unbuildable cmd/cdi.

@klihub
cmd/cdi: update/fix go.{mod,sum}.
ad5beee 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested review from bart0sh and elezar February 2, 2023 20:04
elezar
elezar approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something that builds the CLI in our PRs?

@klihub
Copy link
Contributor Author

klihub commented Feb 2, 2023 •
edited

Is there something that builds the CLI in our PRs?

Yes, there is. The sanity workflow verifies among other things that (test) binaries build on multiple platforms.
I think breakage was able to sneak in because there were at least one other deps-touching PR filed and merged between filing and merging the mod-splitting PR. There were no conflicts, but when these met in the tree, the deps in cmd/cdi were not in sync with the main tree, so the build failed.

@elezar elezar merged commit 0a1a5be into cncf-tags:main Feb 2, 2023
@klihub klihub deleted the fixes/cmd-cdi-deps branch February 3, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elezar elezar elezar approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@klihub @elezar