Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readme #109

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Fix readme #109

merged 2 commits into from
Feb 14, 2023

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Feb 9, 2023

This:

  • fixes the new issue link
  • updates the example
  • adds a description of a fully-qualified device name

Closes #105

@elezar
Minor edits to readme
8087646 
Fix link for filing issues and update podman example.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
Add description of a fully-qualified device name
d283334 
This addresses cncf-tags#105

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar requested review from bart0sh and klihub February 9, 2023 15:40
klihub
klihub approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bart0sh
Copy link
Contributor

bart0sh commented Feb 14, 2023

/lgtm

@bart0sh bart0sh merged commit 951edbb into cncf-tags:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klihub klihub klihub approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Describe qualified device name in the documentation
3 participants
@elezar @bart0sh @klihub