cmd/validate: print the validation errors #163
Conversation
marquiz
force-pushed
the
devel/validate-fix
branch
from
de5f967
to
644ab35
Compare
cmd/cdi/cmd/validate.go
Outdated
| for path, specErrors := range cdiErrors { | ||
| fmt.Printf("Spec file %s:\n", path) | ||
| for idx, err := range specErrors { | ||
| fmt.Printf(" %d: %v\n", idx, strings.TrimRight(err.Error(), "\n")) |
There was a problem hiding this comment.
What about just:
| fmt.Printf(" %d: %v\n", idx, strings.TrimRight(err.Error(), "\n")) | |
| fmt.Printf(" %d: %v\n", idx, strings.Trim(err.Error())) |
We should be ok to just ignore all leading and trailing whitespace in error messages.
There was a problem hiding this comment.
Makes sense. Changed it to strings.TrimSpace()
marquiz
force-pushed
the
devel/validate-fix
branch
2 times, most recently
from
374b1d9
to
e2171b1
Compare
cmd/cdi/cmd/validate.go
Outdated
| for path, specErrors := range cdiErrors { | ||
| fmt.Printf("Spec file %s:\n", path) | ||
| for idx, err := range specErrors { | ||
| fmt.Printf(" %d: %v\n", idx, strings.TrimSpace(err.Error())) |
There was a problem hiding this comment.
Thanks for the update. As a matter of interest, do we want to use tabs instead of spaces here so that the columns are aligned? This really isn't a blocker though, and I'm happy to approve as is.
There was a problem hiding this comment.
Instead of using tabs I now changed this to %3d so it will reserve 3 chars for the idx. Will get unaligned if there are more than 999 errors
There was a problem hiding this comment.
Actually, that would be 999 errors per spec. I changed it to %2d so it will get unaligned after 99 errors per spec
marquiz
force-pushed
the
devel/validate-fix
branch
from
e2171b1
to
2c3c447
Compare
Print out any errors encountered during validation, as suggested by the command help. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
force-pushed
the
devel/validate-fix
branch
from
2c3c447
to
1078daf
Compare
Print out any errors encountered during validation, as suggested by the command help.