Decrease GitHub.com/opencontainers/runtime spec #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
decrease-github.com/opencontainers/runtime-spec
branch
2 times, most recently
from
34b3a78
to
a154cc2
Compare
marquiz
reviewed
Apr 16, 2024
|
I'm not too concerned with the cmd dependencies since they're not imported into downstream dependencies. I suppose it does make sense to update them though. |
elezar
force-pushed
the
decrease-github.com/opencontainers/runtime-spec
branch
from
a154cc2
to
d1cd84a
Compare
Yeah, I'm not that concerned either, just for consistency as I noticed that cmd/validate was updated, too |
klihub
approved these changes
Apr 16, 2024
The IntelRDT fields were added in v1.0.2. and v1.1.0. We use this latter as the minimum version. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
decrease-github.com/opencontainers/runtime-spec
branch
from
d1cd84a
to
ce887d5
Compare
klihub
approved these changes
Apr 16, 2024
|
Fair enough, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are essenitally a library, we need to specify the MINIMUM version of the OCI runtime specification that we need.
This change:
IntelRdt.EnableCMTandIntelRdt.EnableMBMfields wer added).closes #201