Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated landscape block to use landscape 2 scripts #820

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Updated landscape block to use landscape 2 scripts #820

merged 1 commit into from
Jan 7, 2024

Conversation

cjyabraham
Copy link
Collaborator

@cjyabraham cjyabraham commented Jan 3, 2024

As per #819

Pages with landscape 2 embedded:

Notes:

  1. One difference is that when you click on a tile in the new landscape, it pops open a new tab and opens the modal popup for the particular tile. The old landscape would just open the modal directly within the iframe. I'm not sure if this is a problem but just wanted to call it out.
  2. Since the tiles don't show any metadata, the two Juniper tiles on the CNF page appear to be the same when they're not. Maybe we can live with this?
  3. The Certified Kubernetes listing includes an extra category: "PaaS/Container Service (21)", which is not listed on the current landscape listing. Not sure if this is desired or not?

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
@tegioz
Copy link

tegioz commented Jan 4, 2024

This looks great @cjyabraham 🙂

Some comments to your notes:

  1. This was intentional to drive more traffic to the landscape site. These views are embedded in other sites in addition to the CNCF website and users may find interesting to discover the full landscape experience. But we can change how this works. Or maybe as an intermediate point, we could display some more information when hovering over an item (like we do on the landscape site, showing a small card) and keep the click behavior as it is.

  2. We'd like to add more styles for the tiles in addition to the 3 supported right now. We could add one with the items names, or even a card style that would look similar to the card view mode. Just let us know which one you'd prefer and we'll take care of it.

  3. At the moment it's possible to embed either a full category (with all its subcategories) or a single subcategory. We've done this in a generic way so that it can be used across all landscapes: there's nothing CNCF specific or pre-configured in any way, it's all dynamic. But we could try to make the content selection a bit more fine grained if needed and allow to exclude certain subcategories when displaying a full category.

@cjyabraham
Copy link
Collaborator Author

cjyabraham commented Jan 5, 2024

@caniszczyk do you have any thoughts on the above points? If good enough for now, should I go ahead and deploy?

@tegioz for (2), I could see having the titles added and also the full card view mode would both be useful embed formats.

@tegioz
Copy link

tegioz commented Jan 5, 2024

@tegioz for (2), I could see having the titles added and also the full card view mode would both be useful embed formats.

Cool, we'll get it done 👍

@caniszczyk
Copy link

caniszczyk commented Jan 6, 2024 via email

@cjyabraham cjyabraham merged commit 8ca1f28 into main Jan 7, 2024
5 checks passed
@cjyabraham cjyabraham deleted the l2 branch January 7, 2024 11:46
@cjyabraham
Copy link
Collaborator Author

Ok, these are live:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants