Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landscape: add minikube #525

Merged
merged 1 commit into from
Apr 11, 2018
Merged

landscape: add minikube #525

merged 1 commit into from
Apr 11, 2018

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Apr 11, 2018

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • Are you only including a repo_url if your project is 100% open source?
  • If it is open source, does your project have at least 250 GitHub stars?
  • Have you picked the single best category for your project?
  • Does it follow the other guidelines from the new entries section?
  • Are you including an SVG or (less preferably) a large PNG?
  • Does your logo clearly state the name of the project/product and follow the other logo guidelines?
  • Does your project/product name match the text on the logo?
  • Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
  • 2 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Few comments:

  • I added a new subcategory, local development under "App Definition and Development". Is that category supposed to contain developer tooling? Minikube could also fit under "provisioning", since it does provision a local cluster.

@CNCF-Bot
Copy link
Contributor

CNCF-Bot commented Apr 11, 2018

Deploy preview for landscape ready!

Built with commit a2de4d7

https://deploy-preview-525--landscape.netlify.com

@dankohn
Copy link
Contributor

dankohn commented Apr 11, 2018

We're not going to create a new category now. Let's put it in Application Definition since it's often using in the process of developing an app.

I would also encourage you to engage in the effort that will be starting up to redefine the CNCF reference architecture that could create a new box for these tools: cncf/toc#90

@r2d4
Copy link
Contributor Author

r2d4 commented Apr 11, 2018

Thanks! How do I get involved with that effort other than following the issue?

I'll update the PR shortly to put it under app def.

@r2d4 r2d4 force-pushed the minikube branch 2 times, most recently from 6213aba to 8c6e907 Compare April 11, 2018 21:45
@@ -1534,6 +1534,12 @@ landscape:
logo: ./hosted_logos/kubevirt.svg
twitter: 'https://twitter.com/kubevirt'
crunchbase: 'https://www.crunchbase.com/organization/kubevirt'
- item:
name: Minikube
homepage_url: 'https://github.com/kubernetes/minikube'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We trigger whether it's open source based on the presence of the repo_url. You want to do:

homepage_url: 'https://kubernetes.io/docs/getting-started-guides/minikube/'
repo_url: 'https://github.com/kubernetes/minikube'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup sorry I just added that. It should be in this commit already

@r2d4
Copy link
Contributor Author

r2d4 commented Apr 11, 2018

LGTM now! I think its ready for a look.

@dankohn dankohn merged commit 903b640 into cncf:master Apr 11, 2018
@r2d4 r2d4 deleted the minikube branch April 11, 2018 22:20
@r2d4
Copy link
Contributor Author

r2d4 commented Apr 11, 2018

Thanks!

AndreyKozlov1984 pushed a commit to AndreyKozlov1984/landscape that referenced this pull request Nov 18, 2018
AndreyKozlov1984 pushed a commit to AndreyKozlov1984/landscape that referenced this pull request Nov 18, 2018
AndreyKozlov1984 pushed a commit to AndreyKozlov1984/landscape that referenced this pull request Nov 18, 2018
AndreyKozlov1984 pushed a commit that referenced this pull request Nov 18, 2018
AndreyKozlov1984 pushed a commit that referenced this pull request Nov 19, 2018
AndreyKozlov1984 pushed a commit that referenced this pull request Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants