-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
landscape: add minikube #525
Conversation
Deploy preview for landscape ready! Built with commit a2de4d7 |
We're not going to create a new category now. Let's put it in Application Definition since it's often using in the process of developing an app. I would also encourage you to engage in the effort that will be starting up to redefine the CNCF reference architecture that could create a new box for these tools: cncf/toc#90 |
Thanks! How do I get involved with that effort other than following the issue? I'll update the PR shortly to put it under app def. |
6213aba
to
8c6e907
Compare
@@ -1534,6 +1534,12 @@ landscape: | |||
logo: ./hosted_logos/kubevirt.svg | |||
twitter: 'https://twitter.com/kubevirt' | |||
crunchbase: 'https://www.crunchbase.com/organization/kubevirt' | |||
- item: | |||
name: Minikube | |||
homepage_url: 'https://github.com/kubernetes/minikube' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We trigger whether it's open source based on the presence of the repo_url
. You want to do:
homepage_url: 'https://kubernetes.io/docs/getting-started-guides/minikube/'
repo_url: 'https://github.com/kubernetes/minikube'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup sorry I just added that. It should be in this commit already
LGTM now! I think its ready for a look. |
Thanks! |
Former-commit-id: a7fd212
Former-commit-id: a7fd212
Pre-submission checklist:
Please check each of these after submitting your pull request:
repo_url
if your project is 100% open source?Few comments: