Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charter proposal for app-development-wg #638

Merged
merged 12 commits into from
Jun 10, 2024
Merged

Conversation

salaboy
Copy link
Collaborator

@salaboy salaboy commented Apr 29, 2024

This PR includes the content of the Charter definition for the Application Development Working Group. The content was discussed in the following google doc: https://docs.google.com/document/d/1N_47QytSqi8-PW4wjnLBN5EDEArC_YDT5QgfN-r7nSY/edit

In parallel, there currently a nomination for the Working Group Chairs here: #627

@ThomasVitale @danieloh30 please check if everything looks ok to you folks. .

@lianmakesthings @thschue Also, let me know if the structure is right or if changes are needed.

Signed-off-by: salaboy <Salaboy@gmail.com>
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit 4ee4346
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/6661d9e7535d9800087cf900
😎 Deploy Preview https://deploy-preview-638--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danieloh30
Copy link
Collaborator

@salaboy Shouldn't the chapter document include only the content based on the standard template rather than internal discussions (e.g., Deliverables, Target Personas)? I think we need to remove the pages 9 - 14.

@salaboy
Copy link
Collaborator Author

salaboy commented Apr 29, 2024

@danieloh30 that is correct.. check the PR content: https://github.com/cncf/tag-app-delivery/pull/638/files

@danieloh30
Copy link
Collaborator

@danieloh30 that is correct.. check the PR content: https://github.com/cncf/tag-app-delivery/pull/638/files

Cool! I didn't see the content PR in the PR :)

@ThomasVitale
Copy link
Collaborator

@salaboy it looks good! I only left a comment about formatting.

Co-authored-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
@salaboy
Copy link
Collaborator Author

salaboy commented Apr 30, 2024

@ThomasVitale thanks a lot for that! I was waiting to check the rendering

@salaboy
Copy link
Collaborator Author

salaboy commented Apr 30, 2024

@danieloh30 @ThomasVitale I tried to make the diagrams a bit better.. I think that they are a bit clearer now.. but there is a lot of room for improvements

Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested several changes for terminology consistency as well as scope/clarification.

app-development-wg/charter/README.md Outdated Show resolved Hide resolved
app-development-wg/charter/README.md Outdated Show resolved Hide resolved
app-development-wg/charter/README.md Outdated Show resolved Hide resolved
app-development-wg/charter/README.md Outdated Show resolved Hide resolved
app-development-wg/charter/README.md Outdated Show resolved Hide resolved
app-development-wg/charter/README.md Outdated Show resolved Hide resolved
app-development-wg/charter/README.md Outdated Show resolved Hide resolved
app-development-wg/charter/README.md Outdated Show resolved Hide resolved
app-development-wg/charter/README.md Outdated Show resolved Hide resolved
app-development-wg/charter/README.md Outdated Show resolved Hide resolved
salaboy and others added 8 commits May 16, 2024 18:04
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Co-authored-by: Emily Fox <33327273+TheFoxAtWork@users.noreply.github.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
@lianmakesthings lianmakesthings self-requested a review June 10, 2024 13:14
Copy link
Collaborator

@lianmakesthings lianmakesthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by the TOC in cncf/toc#1311.
Congratulations to the team! Excited to see what will come out of this WG 🚀

@lianmakesthings lianmakesthings merged commit e49fd96 into cncf:main Jun 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants