Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub out CNCF resources section. #599

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Stub out CNCF resources section. #599

merged 8 commits into from
Feb 29, 2024

Conversation

jeefy
Copy link
Member

@jeefy jeefy commented Feb 13, 2024

  • Stubbed out multiple pages for the CNCF to populate
  • Moved TAG-CS videos into the About page (made sense to me as the videos were more TAG-CS specific, and the About page is primarily TAG-CS.
  • Removed Templates "page" since it simply linked to the Templates in the "Maintainers" section
  • Added descriptions to all links/sub-pages for consistency sake

Once this gets OK'd and merged in, CNCF folks will be updating this skeleton with quite a bit of content that we have staged across various docs :)

/cc @krook @castrojo @amye

@jberkus
Copy link
Contributor

jberkus commented Feb 13, 2024

Hey, in your PR you renamed a bunch of files that weren't created by CNCF staff. Mistake?

If it wasn't a mistake, can you please explain what the renaming is about?

…out (where tag-cs is more referenced)

Signed-off-by: Jeffrey Sica <me@jeefy.dev>
Signed-off-by: Jeffrey Sica <me@jeefy.dev>
@jeefy
Copy link
Member Author

jeefy commented Feb 15, 2024

Review bump! I think all the changes/reverts are done. :)

@jeefy
Copy link
Member Author

jeefy commented Feb 21, 2024

Ping. :) @jberkus @geekygirldawn <3

Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I have a few suggestions. Instead of leaving some pages blank, can we add links to existing docs if they exist? When the content is being moved, these links can be removed.

I wouldn't want to see blank pages in this website.

2 other alternatives:

  • Working in a feature branch until the existing pages have content (not all of them has to be moved immediately)
  • Hiding the pages (also their parents too, if they don't have any non-blank subpage)

jeefy and others added 3 commits February 28, 2024 12:45
…index.md

Co-authored-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Jeffrey Sica <jeef111x@gmail.com>
Co-authored-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Jeffrey Sica <jeef111x@gmail.com>
…ndex.md

Co-authored-by: Ali Ok <aliok@redhat.com>
Signed-off-by: Jeffrey Sica <jeef111x@gmail.com>
@jeefy
Copy link
Member Author

jeefy commented Feb 28, 2024

@aliok added your suggestions. The intent is once this is merged we're going to have people from across the CNCF updating these pages pretty fast, as we want to be able to chat with folks about it at KubeCon EU. So if the pages are blank, they won't be blank for long (like... a couple days)

@aliok
Copy link
Member

aliok commented Feb 29, 2024

Thanks @jeefy , all good on my side then.

Let's merge this one to unblock the people across CNCF to update the pages!

@aliok aliok enabled auto-merge (squash) February 29, 2024 06:16
@aliok aliok merged commit 7cb8a14 into cncf:main Feb 29, 2024
2 checks passed
@jeefy
Copy link
Member Author

jeefy commented Feb 29, 2024

Thanks all! Now the real work begins 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants