-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub out CNCF resources section. #599
Conversation
dba2098
to
87dcd68
Compare
Hey, in your PR you renamed a bunch of files that weren't created by CNCF staff. Mistake? If it wasn't a mistake, can you please explain what the renaming is about? |
87dcd68
to
3953c46
Compare
…out (where tag-cs is more referenced) Signed-off-by: Jeffrey Sica <me@jeefy.dev>
3953c46
to
8a3f10e
Compare
Signed-off-by: Jeffrey Sica <me@jeefy.dev>
d71a884
to
ba9f66e
Compare
Review bump! I think all the changes/reverts are done. :) |
Ping. :) @jberkus @geekygirldawn <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But I have a few suggestions. Instead of leaving some pages blank, can we add links to existing docs if they exist? When the content is being moved, these links can be removed.
I wouldn't want to see blank pages in this website.
2 other alternatives:
- Working in a feature branch until the existing pages have content (not all of them has to be moved immediately)
- Hiding the pages (also their parents too, if they don't have any non-blank subpage)
website/content/resources/project-services/technical-writing/_index.md
Outdated
Show resolved
Hide resolved
website/content/resources/project-services/license-scanners/_index.md
Outdated
Show resolved
Hide resolved
…index.md Co-authored-by: Ali Ok <aliok@redhat.com> Signed-off-by: Jeffrey Sica <jeef111x@gmail.com>
Co-authored-by: Ali Ok <aliok@redhat.com> Signed-off-by: Jeffrey Sica <jeef111x@gmail.com>
…ndex.md Co-authored-by: Ali Ok <aliok@redhat.com> Signed-off-by: Jeffrey Sica <jeef111x@gmail.com>
@aliok added your suggestions. The intent is once this is merged we're going to have people from across the CNCF updating these pages pretty fast, as we want to be able to chat with folks about it at KubeCon EU. So if the pages are blank, they won't be blank for long (like... a couple days) |
Thanks @jeefy , all good on my side then. Let's merge this one to unblock the people across CNCF to update the pages! |
Thanks all! Now the real work begins 😁 |
Moved TAG-CS videos into the About page (made sense to me as the videos were more TAG-CS specific, and the About page is primarily TAG-CS.Removed Templates "page" since it simply linked to the Templates in the "Maintainers" sectionOnce this gets OK'd and merged in, CNCF folks will be updating this skeleton with quite a bit of content that we have staged across various docs :)
/cc @krook @castrojo @amye