Skip to content

Commit

Permalink
CEL Matchers: remove extension tag until implemented (#36)
Browse files Browse the repository at this point in the history
Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
  • Loading branch information
sergiitk committed May 20, 2022
1 parent d35b9e6 commit 1e77728
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion xds/type/matcher/v3/cel.proto
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ option (xds.annotations.v3.file_status).work_in_progress = true;
// for usage details.
//
// [#comment:TODO(sergiitk): Link HttpAttributesMatchInput + usage example.]
// [#comment:TODO(sergiitk): Add extension category.]
// [#comment:TODO(sergiitk): When implemented, add the extension tag.]
message CelMatcher {
// Either parsed or checked representation of the CEL program.
type.v3.CelExpression expr_match = 1 [(validate.rules).message = {required: true}];
Expand Down
2 changes: 1 addition & 1 deletion xds/type/matcher/v3/http_inputs.proto
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ option (xds.annotations.v3.file_status).work_in_progress = true;
// Refer to :ref:`Unified Matcher API <envoy_v3_api_msg_.xds.type.matcher.v3.Matcher>` documentation
// for usage details.
//
// [#extension: envoy.matching.inputs.http_attributes]
// [#comment:TODO(sergiitk): When implemented, add the extension tag.]
message HttpAttributesCelMatchInput {
}
2 changes: 1 addition & 1 deletion xds/type/v3/cel.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ message CelExpression {
// Besides CEL evaluation raising an error explicitly, CEL program returning a type other than
// the ``string``, or not returning anything, are considered an error as well.
//
// [#comment:TODO(sergiitk): Add extension category.]
// [#comment:TODO(sergiitk): When implemented, add the extension tag.]
message CelExtractString {
// The CEL expression used to extract a string from the CEL environment.
// the "subject string") that should be replaced.
Expand Down

0 comments on commit 1e77728

Please sign in to comment.