Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matchers: add action name as opposed to full configuration #28

Closed
wants to merge 1 commit into from

Conversation

kyessenov
Copy link
Contributor

@kyessenov kyessenov commented Feb 23, 2022

This is useful to reduce verbosity for string-value actions, e.g. picking a listener by name using the unified matchers.
Generally applicable to situations where many leaves are identical in a match tree.

Signed-off-by: Kuat Yessenov kuat@google.com

Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
Copy link
Contributor Author

CC @snowp

@markdroth
Copy link
Contributor

I assume this would work by passing in a map of name to action when invoking the matcher tree?

I'm okay with this in principle. @snowp, any concerns?

@kyessenov
Copy link
Contributor Author

Yes, there is too much boilerplate when using string-valued actions (see the linked PR). Open to other ways but this looked least disruptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants