unified matcher: minor refactor of matcher API #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wangbaiping wbphub@live.com
This is PR more like a sudden advice. This matcher API is still be marked as
work_in_progress, So, maybe it's ok to update the API directly?What this PR did:
PredicateList.predicate->PredicateList.listIn the previous API, the
PredicateList.predicatehas same field name with theFieldMatcher.predicate. It makes the configuration hard to read and to understand. Rename it tolist, just as theMatchMap.map.Predicate.*matchertoPredicate.*predicate[s]Unify the name of fields of
Predicateand make the name much the meaning of field better.