Add application_utilization #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yousuk Seung <ysseung@google.com>
markdroth
reviewed
Jun 5, 2023
|
LGTM. I'd like to get a non-gRPC review from @htuch. Also, looks like the DCO check is failing. @yousukseung, please fix. |
htuch
approved these changes
Jun 6, 2023
|
Please fix DCO! |
Signed-off-by: Yousuk Seung <ysseung@google.com>
Fixed. |
sergiitk
pushed a commit
to sergiitk/xds
that referenced
this pull request
Oct 6, 2023
gRPC's client-side weighted round robin currently uses 'cpu_utilization' but the load balancing works with any utilization. Server applications that are not CPU bound can report an application specific utilization metric instead and balance the load better. This change introduces a new top-level field 'application_utilization' for this use. Signed-off-by: Yousuk Seung <ysseung@google.com> Signed-off-by: Sergii Tkachenko <sergiitk@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC's client-side weighted round robin currently uses 'cpu_utilization' but the load balancing works with any utilization. Server applications that are not CPU bound can report an application specific utilization metric instead and balance the load better. This change introduces a new top-level field 'application_utilization' for this use.