Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate buf.build with bazel #82

Closed
wants to merge 3 commits into from
Closed

integrate buf.build with bazel #82

wants to merge 3 commits into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Feb 5, 2024

I followed https://buf.build/docs/build-systems/bazel to provide buf.build rules with bazel

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice @mmorel-35 thanks for following up - ive been a bit busy recently

wondering if pgv update should be separated

(also, please fix the missing newlines please)

@mmorel-35
Copy link
Contributor Author

wondering if pgv update should be separated

I removed it now

also, please fix the missing newlines please

It's done :)

@mmorel-35 mmorel-35 marked this pull request as ready for review February 5, 2024 21:06
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as draft February 11, 2024 11:22
@mmorel-35 mmorel-35 closed this by deleting the head repository Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants