Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize dependencies versions between go.mod and bazel #85

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

mmorel-35
Copy link
Contributor

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Feb 21, 2024

Hi @adisuissa ,
Do you need someone else's approval to merge?
Maybe @phlax ?

@phlax
Copy link
Member

phlax commented Feb 21, 2024

im not an api/xds maintainer

@mmorel-35
Copy link
Contributor Author

im not an api/xds maintainer

I thought so because of the relation with envoy . Sorry for the misunderstanding

@phlax
Copy link
Member

phlax commented Feb 21, 2024

np - envoy does have api-shepherds which are the same maintainers here i believe

@mmorel-35
Copy link
Contributor Author

Hi @adisuissa ,
Anything to add to merge this as it’s validated ?

@adisuissa adisuissa merged commit 91a88dc into cncf:main Mar 6, 2024
4 checks passed
@mmorel-35 mmorel-35 deleted the synchronize-dependencies branch March 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants